On 4/13/22 8:34 AM, Arun Ajith S wrote: > diff --git a/tools/testing/selftests/net/ndisc_unsolicited_na_test.py b/tools/testing/selftests/net/ndisc_unsolicited_na_test.py > new file mode 100755 > index 000000000000..f508657ee126 > --- /dev/null > +++ b/tools/testing/selftests/net/ndisc_unsolicited_na_test.py > @@ -0,0 +1,255 @@ > +#!/bin/bash that file name suffix should be .sh since it is a bash script; not .py other than that looks good to me. Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>