> It feels strange to force the user to use "realtek,rtl8365mb" or any > other different string that does not match the chip's real name. I > would not expect the one writing the DT to know that rtl8367s shares > the same family with rtl8365mb and rtl8365mb driver does support > rtl8367s. Before writing the rtl8367s driver, I also didn't know the > relation between those chips. The common was only to relate rtl8367s > (or any other chip model) with the vendor driver rtl8367c. As we don't > have a generic family string, I think it is better to add every model > variant. I will just quote the Marvell mv88e6xxx binding: The compatibility string is used only to find an identification register, which is at a different MDIO base address in different switch families. - "marvell,mv88e6085" : Switch has base address 0x10. Use with models: 6085, 6095, 6097, 6123, 6131, 6141, 6161, 6165, 6171, 6172, 6175, 6176, 6185, 6240, 6320, 6321, 6341, 6350, 6351, 6352 - "marvell,mv88e6190" : Switch has base address 0x00. Use with models: 6190, 6190X, 6191, 6290, 6390, 6390X - "marvell,mv88e6250" : Switch has base address 0x08 or 0x18. Use with model: 6220, 6250 This has worked well for that driver. Andrew