Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
From: Jason Gunthorpe <jgg@xxxxxxxxxx>
Date: Wed, 13 Apr 2022 10:39:27 -0300
Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Tony Krowiak <akrowiak@xxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Eric Farman <farman@xxxxxxxxxxxxx>, Harald Freudenberger <freude@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Jason Herne <jjherne@xxxxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Kirti Wankhede <kwankhede@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>, Zhi Wang <zhi.a.wang@xxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Liu, Yi L" <yi.l.liu@xxxxxxxxx>
In-reply-to: <20220413060008.GE32092@lst.de>
References: <0-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com> <5-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com> <20220413060008.GE32092@lst.de>

On Wed, Apr 13, 2022 at 08:00:08AM +0200, Christoph Hellwig wrote:
> This looks good execept the extern nitpick:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> However I'd move this before the previous patch.  More of the explanation
> there.

Yes, that looks good, done

Thanks,
Jason

References:
- [PATCH 0/9] Make the rest of the VFIO driver interface use vfio_device
  - From: Jason Gunthorpe
- [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
  - From: Jason Gunthorpe
- Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH v8 3/4] bootconfig: Support embedding a bootconfig file in kernel
Next by Date: Re: [PATCH 4/9] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages
Previous by thread: Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()
Next by thread: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]