Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jason Gunthorpe <jgg@xxxxxxxxxx>
Subject: Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 13 Apr 2022 07:57:17 +0200
Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Tony Krowiak <akrowiak@xxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Eric Farman <farman@xxxxxxxxxxxxx>, Harald Freudenberger <freude@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Jason Herne <jjherne@xxxxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Kirti Wankhede <kwankhede@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>, Zhi Wang <zhi.a.wang@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Liu, Yi L" <yi.l.liu@xxxxxxxxx>
In-reply-to: <3-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com>
References: <0-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com> <3-v1-a8faf768d202+125dd-vfio_mdev_no_group_jgg@nvidia.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> -	extern int vfio_pin_pages(struct device *dev, unsigned long *user_pfn,
> +	extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn,
>  				  int npage, int prot, unsigned long *phys_pfn);
>  
> -	extern int vfio_unpin_pages(struct device *dev, unsigned long *user_pfn,
> +	extern int vfio_unpin_pages(struct vfio_device *vdev, unsigned long *user_pfn,

Please drop the externs when you touch this (also for the actual
header).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
  - From: Jason Gunthorpe

References:
- [PATCH 0/9] Make the rest of the VFIO driver interface use vfio_device
  - From: Jason Gunthorpe
- [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
  - From: Jason Gunthorpe

Prev by Date: Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device
Next by Date: Re: [PATCH 6/9] drm/i915/gvt: Add missing module_put() in error unwind
Previous by thread: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
Next by thread: Re: [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]