Re: [PATCH] docs: sphinx/requirements: Limit jinja2<3.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/29/22 16:51, Akira Yokosawa wrote:
> On Tue, 29 Mar 2022 08:36:23 -0700,
> Randy Dunlap wrote:
>>
>> On 3/29/22 08:31, Jonathan Corbet wrote:
>>> Akira Yokosawa <akiyks@xxxxxxxxx> writes:
>>>
>>>> jinja2 release 3.1.0 (March 24, 2022) broke Sphinx<4.0.
>>>> This looks like the result of deprecating Python 3.6.
>>>> It has been tested against Sphinx 4.3.0 and later later.
>>>
>>> *Sigh*.  I wish this stuff didn't feel like such a house of cards
>>> sometimes... 
>>
>> ack.
>>
>>>> Setting an upper limit of <3.1 to junja2 can unbreak Sphinx<4.0
>>>> including Sphinx 2.4.4.
>>>>
>>>> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
>>>> Cc: Jonathan Corbet <corbet@xxxxxxx>
>>>> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>>>> Cc: linux-doc@xxxxxxxxxxxxxxx
>>>> ---
>>>> Or we can bump the requirement to Sphinx>=4.0.
>>>> Thoughts?
>>>
>>> It's probably time to consider a bump there, but that is a bigger one
>>> than I would want to do at this point.  So I'll just fast-track this
>>> patch in; dropping it into the stable updates probably makes sense too.
>>
>> Yeah, some of us don't have Python4 installed...
> 
> You can run Sphinx 4.5.0 with Python>=3.6.
> (jinja2>3.1 requires Python>=3.7, though.)
> 
> A requirement list for installing latest Sphinx for kerneldoc would be
> a single line of:
> 
> ----
> sphinx_rtd_theme
> ----
> 
> Or for Python 3.6,
> 
> ----
> jinja2<3.1
> sphinx_rtd_theme
> ----
> 
> should work (tested with Python 3.6.9 on Ubuntu 18.04).
> That is, give or take the occasional breakages caused by a conflict
> between updated dependent packages or updated dependencies.
> 
> We can't be safe just by pinning Sphinx version.  Old Sphinx can't
> know of breakages by future updates in its dependencies.
> To avoid this, we need to pin every dependent package.
> I'm not sure this is the right thing to do, though...

Hi Akira,
Thanks for the tips.
However, I think that I misread Sphinx.4+ as Python4. :(

-- 
~Randy



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux