Hi, Arnd, On Mon, Mar 21, 2022 at 6:48 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Mon, Mar 21, 2022 at 9:46 AM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote: > > On Mon, Mar 21, 2022 at 4:38 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > > On Sat, Mar 19, 2022 at 3:38 PM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote: > > > > > > > +unsigned long eentry; > > > > +EXPORT_SYMBOL_GPL(eentry); > > > > +unsigned long tlbrentry; > > > > +EXPORT_SYMBOL_GPL(tlbrentry); > > > > > > Why are these exported to modules? Maybe add a comment here, or remove > > > the export if it's not actually needed. > > > > They are used by the kvm module in our internal repo. > > Ok, that is fine then. For the moment, please add a comment about it here, > or remove the exports in the initial merge and add them back when you > submit the kvm code. OK, I will remove them. Huacai > > Arnd
