Tang Yizhou <tangyizhou@xxxxxxxxxx> writes:
> All other scheduler documents have been converted to *.rst. Let's do
> the same for schedutil.txt.
>
> Signed-off-by: Tang Yizhou <tangyizhou@xxxxxxxxxx>
> ---
> Documentation/scheduler/index.rst | 1 +
> .../{schedutil.txt => schedutil.rst} | 50 ++++++++++---------
> 2 files changed, 28 insertions(+), 23 deletions(-)
> rename Documentation/scheduler/{schedutil.txt => schedutil.rst} (85%)
I would like to see this change made so that this document can be built
with the rest of the kernel docs. I will, however, defer to Peter and
will not accept this change over his objections.
That said, there is one other issue...
[...]
> --- a/Documentation/scheduler/schedutil.txt
> +++ b/Documentation/scheduler/schedutil.rst
> @@ -1,11 +1,15 @@
> +=========
> +Schedutil
> +=========
>
> +.. note::
>
> -NOTE; all this assumes a linear relation between frequency and work capacity,
> -we know this is flawed, but it is the best workable approximation.
> + All this assumes a linear relation between frequency and work capacity,
> + we know this is flawed, but it is the best workable approximation.
>
>
> PELT (Per Entity Load Tracking)
> --------------------------------
> +===============================
>
> With PELT we track some metrics across the various scheduler entities, from
> individual tasks to task-group slices to CPU runqueues. As the basis for this
> @@ -38,8 +42,8 @@ while 'runnable' will increase to reflect the amount of contention.
> For more detail see: kernel/sched/pelt.c
>
>
> -Frequency- / CPU Invariance
> ----------------------------
> +Frequency / CPU Invariance
> +==========================
>
> Because consuming the CPU for 50% at 1GHz is not the same as consuming the CPU
> for 50% at 2GHz, nor is running 50% on a LITTLE CPU the same as running 50% on
> @@ -47,23 +51,23 @@ a big CPU, we allow architectures to scale the time delta with two ratios, one
> Dynamic Voltage and Frequency Scaling (DVFS) ratio and one microarch ratio.
>
> For simple DVFS architectures (where software is in full control) we trivially
> -compute the ratio as:
> +compute the ratio as::
>
> - f_cur
> + f_cur
You would appear to have done some space-to-tab conversions throughout
the file which muddies up the diff and makes it harder to see what you
have really changed. Please redo the patch without unneeded white-space
changes.
Thanks,
jon
