On Thu, Mar 10, 2022 at 05:52:16PM -0800, Andrew Morton wrote: > On Thu, 10 Mar 2022 16:09:26 -0600 Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > > There are no users of "__bitwise__" except the definition of "__bitwise". > > Remove __bitwise__ and define __bitwise directly. > > > > This is a follow-up to 05de97003c77 ("linux/types.h: enable endian checks > > for all sparse builds"). > > > > Can we change the copy-pasted code in tools/include/linux/types.h while > we're there? Oh, you bet! Thanks for pointing that out! > --- a/tools/include/linux/types.h~linux-typesh-remove-unnecessary-__bitwise__-fix > +++ a/tools/include/linux/types.h > @@ -43,11 +43,10 @@ typedef __u8 u8; > typedef __s8 s8; > > #ifdef __CHECKER__ > -#define __bitwise__ __attribute__((bitwise)) > +#define __bitwise __attribute__((bitwise)) > #else > -#define __bitwise__ > +#define __bitwise > #endif > -#define __bitwise __bitwise__ > > #define __force > #define __user > _ >