On 3/10/22 10:32, Mike Rapoport wrote: > Hi, > > On Mon, Mar 07, 2022 at 12:24:55PM +0000, Joao Martins wrote: >> In preparation for device-dax for using hugetlbfs compound page tail >> deduplication technique, move the comment block explanation into a >> common place in Documentation/vm. >> >> Cc: Muchun Song <songmuchun@xxxxxxxxxxxxx> >> Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx> >> Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx> >> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> >> Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> >> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> >> --- >> Documentation/vm/index.rst | 1 + >> Documentation/vm/vmemmap_dedup.rst | 173 +++++++++++++++++++++++++++++ > > Sorry for jumping late. > > Please consider moving this into Documentation/vm/memory-model.rst along > with the documentation added in the next patch > Hmmm, I don't think this is the right place to put it. We don't change the memory model fundamentally (rather the *backing* pages of vmemmap VA in some specific cases) to justify putting the entire thing there. The new doc is also just as big as memory-model.rst doc. I feel the two separate docs stand on their own and the vmemmap dedup technique doc is better placed as its own. Perhaps alternatively (in a followup patch) it could get a relevant mention (either in an new subsection or in paragraphs of the existing subsections) in memory-model.rst to point readers to vmemmap_dedup.rst...?
