On Tue, May 28, 2013 at 12:03:14AM +0200, Arnaud Ebalard wrote:
>
> Signed-off-by: Arnaud Ebalard <arno@xxxxxxxxxxxx>
> ---
> drivers/hwmon/Kconfig | 10 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/g762.c | 1012 ++++++++++++++++++++++++++++++++++++
> include/linux/platform_data/g762.h | 54 ++
> 4 files changed, 1077 insertions(+)
> create mode 100644 drivers/hwmon/g762.c
> create mode 100644 include/linux/platform_data/g762.h
Hi Arnaud,
After more tests on my 2Big Network v2 board, it appears that the fan
doesn't rotate when PWM mode (the preferred operating mode for this
board) is selected. Nevertheless, DC mode is usable (even if not ideal
given the hardware). After some investigations I noticed that an extra
initialization is needed to enable PWM mode on my board: the set_cnt
register must be set to 0 while the default value is 0xff. Is that
specific to my hardware ? Is PWM mode working on your ReadyNAS with
the default set_cnt value ?
I haven't noticed this issue while testing your v1 patch series because
at the time I was using a board with an U-Boot modified by LaCie. This
last sets the set_cnt register to 0 while U-Boot mainline don't.
Actually, the 2Big fan is not configured nor even started by U-Boot
mainline. I have to fix this but maybe that something can be done in
the g762 Linux driver too ?
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 0428e8a..142bdf8 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
Snip
> diff --git a/include/linux/platform_data/g762.h b/include/linux/platform_data/g762.h
> new file mode 100644
> index 0000000..29e3934
> --- /dev/null
> +++ b/include/linux/platform_data/g762.h
> @@ -0,0 +1,54 @@
> +/*
> + * Platform data structure for g762 fan controller driver
> + *
> + * Copyright (C) 2013, Arnaud EBALARD <arno@xxxxxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + */
> +#ifndef __LINUX_PLATFORM_DATA_G762_H__
> +#define __LINUX_PLATFORM_DATA_G762_H__
> +
> +#define G762_DEFAULT_NO_OVERLOAD 0xffffffff
> +
> +struct g762_platform_data {
> + u32 fan_startv;
> + u32 fan_gear_mode;
> + u32 fan_div;
> + u32 fan_pulses;
> + u32 fan_target;
> + u32 pwm_polarity;
> + u32 pwm_enable;
> + u32 pwm_freq;
> + u32 pwm_mode;
> +};
> +
> +/* When filling a g762_platform_data structure to be passed during platform
> + * init to the driver, it needs to be initialized to the following default
> + * value before changing specific fields. This is needed to avoid a sparse
> + * initialization to have current values replaced by 0 */
In other places, you use this multi-line comment format:
/*
* ...
* ...
*/
> +
> +static const struct g762_platform_data G762_DEFAULT_PDATA = {
> + .fan_startv = G762_DEFAULT_NO_OVERLOAD,
> + .fan_gear_mode = G762_DEFAULT_NO_OVERLOAD,
> + .fan_div = G762_DEFAULT_NO_OVERLOAD,
> + .fan_pulses = G762_DEFAULT_NO_OVERLOAD,
> + .fan_target = G762_DEFAULT_NO_OVERLOAD,
> + .pwm_polarity = G762_DEFAULT_NO_OVERLOAD,
> + .pwm_enable = G762_DEFAULT_NO_OVERLOAD,
> + .pwm_freq = G762_DEFAULT_NO_OVERLOAD,
> + .pwm_mode = G762_DEFAULT_NO_OVERLOAD,
> +};
Are you sure that all this settings are needed ? IMHO the g762 platform
data should only holds the platform specific configuration: fan_startv,
fan_gear_mode, fan_div and fan_pulses. The other settings are not really
related with the platform but more with the operating fan configuration.
For my part, I am happy enough with the sysfs hwmon interface.
The same comment applies to the g762 DT binding properties.
Regards,
Simon
Attachment:
signature.asc
Description: Digital signature
