On Fri, May 24, 2013 at 8:32 PM, Rohit Vaswani <rvaswani@xxxxxxxxxxxxxx> wrote: > This cleans up the gpio-msm-v2 driver of all the global define usage. > The number of gpios are now defined in the device tree. This enables > adding irqdomain support as well. > > Signed-off-by: Rohit Vaswani <rvaswani@xxxxxxxxxxxxxx> Good clean-up so: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> But here is an unrelated hint for later refactoring: > + msmgpio: gpio@800000 { > + compatible = "qcom,msm-gpio"; > + reg = <0x00800000 0x1000>; > + gpio-controller; > + #gpio-cells = <2>; > + ngpio = <173>; > + interrupts = <0 32 0x4>; If you switch the dts[i] files to use the C preprocessor include syntax you can change all interrupts to look like so: #include <dt-bindings/interrupt-controller/irq.h> interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>; Which is helpful. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html