Re: [PATCH v5 4/5] mm/sparse-vmemmap: improve memory savings for compound devmaps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/12/22 14:49, Muchun Song wrote:
> On Sat, Feb 12, 2022 at 6:08 PM Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>> On Fri, Feb 11, 2022 at 8:37 PM Joao Martins <joao.m.martins@xxxxxxxxxx> wrote:
>>> On 2/11/22 07:54, Muchun Song wrote:
>>>> On Fri, Feb 11, 2022 at 3:34 AM Joao Martins <joao.m.martins@xxxxxxxxxx> wrote:
>>>>> -       if (vmemmap_populate(start, end, nid, altmap))
>>>>> +       if (pgmap && pgmap_vmemmap_nr(pgmap) > 1 && !altmap)
>>>>
>>>> Should we add a judgment like "is_power_of_2(sizeof(struct page))" since
>>>> this optimization is only applied when the size of the struct page does not
>>>> cross page boundaries?
>>>
>>> Totally miss that -- let me make that adjustment.
>>>
>>> Can I ask which architectures/conditions this happens?
>>
>> E.g. arm64 when !CONFIG_MEMCG.
> 
> Plus !CONFIG_SLUB even on x86_64.

Oh, thanks for the ref -- hadn't realized that this was
possible on arm64/x86.



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux