On 2/7/22 11:06 AM, Bird, Tim wrote: > > >> -----Original Message----- >> From: Frank Rowand <frowand.list@xxxxxxxxx> >> >> On 2/7/22 10:38 AM, Frank Rowand wrote: >>> On 2/7/22 10:28 AM, frowand.list@xxxxxxxxx wrote: >>>> From: Frank Rowand <frank.rowand@xxxxxxxx> >>>> >>>> Add the spec version to the title line. >>>> >>>> Explain likely source of "Unknown lines". >>>> >>>> "Unknown lines" in nested tests are optionally indented. >>>> >>>> Add "Unknown lines" items to differences between TAP & KTAP list >>>> >>>> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx> >>>> --- >>> >>> Please do not apply this version (v2). I was working off the KTAP specification >> ^^^^ TAP > > What??? I was looking at the proposed TAP v14 from: branch 'git14' of https://github.com/isaacs/testanything.github.io.git while David was looking at branch 'tap-14-specification' of https://github.com/TestAnything/Specification/ David did not find the line type of "Anything else" in the TAP v14 he was looking at, but did find it in TAP v13 (tap-version-13-specification.md) which is in https://github.com/TestAnything/testanything.github.io so my reference to TAP "Anything else" in the patch remains valid. The lack of "Anything else" in the TAP v14 that David was looking at is why I initially said to not apply this patch (v2). > >>> from a different github repo than I should have been referencing. >> >> OK to proceed with this version of the patch. I was referencing the proposed >> TAP version 14, which is in a different github repo than the TAP version 13 >> specification. Everything in this patch is consistent with TAP version 13, >> as well as the proposed TAP version 14. > > I'm confused by this message. > Will there be a v3 of the patch, or are you saying to just apply the original v2 of > this patch? Sorry for the confusion. There is no longer a need for v3 of the patch, so it is ok to apply v2 if it passes review. > > For the original (v2) of the patch, which I believe is > https://lore.kernel.org/all/20220207162813.3091899-1-frowand.list@xxxxxxxxx/ > > you can add a "Reviewed-by" from me. > -- Tim >
