> Hi, thanks for the review. First of all, notice that it's very likely > this patch isn't gonna get merged this way, we are considering a > refactor that included 2 panic notifiers: one a bit earlier (pre_dump), > that includes functions less risky, as watchdog unloaders, kernel offset > dump, etc, and the second panic notifier (post_dump) will keep the > majority of callbacks, and can be conditionally executed on kdump > through the usage of "crash_kexec_post_notifiers". But the pre_dump cannot avoid calling multiple unnecessary handlers, right? It's more risky than the previous idea... > Anyway, I'm curious with your code review - how can we use this filter > with modules, if the filter setup is invoked as early_param(), before > modules load? In that case, module functions won't have a valid address, > correct? So, in that moment, this lookup fails, we cannot record an > unloaded module address in such list. Please, correct me if I'm wrong. For example, how about simply maintaining function symbol names in the list as string, not address. Thanks. HATAYAMA, Daisuke
