Hi "Rafał, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on char-misc/char-misc-testing linux/master linus/master v5.16-rc6 next-20211217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/sysfs-add-sysfs_add_bin_file_to_group/20211220-144856 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git aa483f3ce655ed9ee4f32d050d1822eec2d20ada config: nds32-allnoconfig (https://download.01.org/0day-ci/archive/20211220/202112202251.hdWPQftO-lkp@xxxxxxxxx/config) compiler: nds32le-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/a9802080b6d35af5dfd7ae847a0978e47caafd59 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Rafa-Mi-ecki/sysfs-add-sysfs_add_bin_file_to_group/20211220-144856 git checkout a9802080b6d35af5dfd7ae847a0978e47caafd59 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash fs/sysfs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> fs/sysfs/file.c:379:5: warning: no previous prototype for '__sysfs_add_file_to_group' [-Wmissing-prototypes] 379 | int __sysfs_add_file_to_group(struct kobject *kobj, | ^~~~~~~~~~~~~~~~~~~~~~~~~ -- fs/sysfs/file.c:383: warning: Function parameter or member 'battr' not described in '__sysfs_add_file_to_group' >> fs/sysfs/file.c:383: warning: expecting prototype for sysfs_add_file_to_group(). Prototype was for __sysfs_add_file_to_group() instead vim +/__sysfs_add_file_to_group +379 fs/sysfs/file.c 372 373 /** 374 * sysfs_add_file_to_group - add an attribute file to a pre-existing group. 375 * @kobj: object we're acting for. 376 * @attr: attribute descriptor. 377 * @group: group name. 378 */ > 379 int __sysfs_add_file_to_group(struct kobject *kobj, 380 const struct attribute *attr, 381 const struct bin_attribute *battr, 382 const char *group) > 383 { 384 struct kernfs_node *parent; 385 kuid_t uid; 386 kgid_t gid; 387 int error; 388 389 if (WARN_ON((attr && battr) || (!attr && !battr))) 390 return -EINVAL; 391 392 if (group) { 393 parent = kernfs_find_and_get(kobj->sd, group); 394 } else { 395 parent = kobj->sd; 396 kernfs_get(parent); 397 } 398 399 if (!parent) 400 return -ENOENT; 401 402 kobject_get_ownership(kobj, &uid, &gid); 403 if (attr) 404 error = sysfs_add_file_mode_ns(parent, attr, attr->mode, uid, 405 gid, NULL); 406 else 407 error = sysfs_add_bin_file_mode_ns(parent, battr, battr->attr.mode, 408 uid, gid, NULL); 409 kernfs_put(parent); 410 411 return error; 412 } 413 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
