Hi Prabhakar, On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: > On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > [Snip] > > >> + > >> + pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); > >> + if (!pdata) > > > > I've started playing with the V4L2 OF bindings, and realized that should > > should call of_node_put() here. > > you were referring of_node_get() here rite ? No, I'm referring to of_node_put(). The v4l2_of_get_next_endpoint() function mentions * Return: An 'endpoint' node pointer with refcount incremented. Refcount * of the passed @prev node is not decremented, the caller have to use * of_node_put() on it when done. > of_node_get/put() got recently added I guess coz of which I missed it :) > > >> + return NULL; > >> + > >> + v4l2_of_parse_endpoint(endpoint, &bus_cfg); > >> + flags = bus_cfg.bus.parallel.flags; > >> + > >> + if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH) > >> + pdata->hs_polarity = 1; > >> + > >> + if (flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH) > >> + pdata->vs_polarity = 1; > >> + > >> + if (flags & V4L2_MBUS_PCLK_SAMPLE_RISING) > >> + pdata->clk_polarity = 1; > >> + > > > > As well as here. Maybe a > > > > done: > > of_node_put(endpoint); > > return pdata; > > > > with a goto done in the devm_kzalloc error path would be better. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
