Re: [PATCH] livepatch: Fix leak on klp_init_patch_early failure path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] livepatch: Fix leak on klp_init_patch_early failure path
From: David Vernet <void@xxxxxxxxxxxxx>
Date: Tue, 14 Dec 2021 10:26:58 -0800
Cc: Petr Mladek <pmladek@xxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, live-patching@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jpoimboe@xxxxxxxxxx, jikos@xxxxxxxxxx, mbenes@xxxxxxx, joe.lawrence@xxxxxxxxxx, corbet@xxxxxxx, yhs@xxxxxx, songliubraving@xxxxxx
In-reply-to: <Ybi9yeEnKqq7HtS5@kroah.com>
References: <20211213191734.3238783-1-void@manifault.com> <YbhZwVocHDX9ZBAc@alley> <Ybi9yeEnKqq7HtS5@kroah.com>

Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote on Tue [2021-Dec-14 16:52:41 +0100]:
> You are FORCED TO call kobject_put() after kobject_init() is called.
> Anything else is a bug.

Ack, thanks for confirming, Greg. I'll send out a v2 of the patch that fixes the
leak and addresses the issue that Josh identified.

- David

References:
- [PATCH] livepatch: Fix leak on klp_init_patch_early failure path
  - From: David Vernet
- Re: [PATCH] livepatch: Fix leak on klp_init_patch_early failure path
  - From: Petr Mladek
- Re: [PATCH] livepatch: Fix leak on klp_init_patch_early failure path
  - From: Greg Kroah-Hartman

Prev by Date: Re: [v4 00/11] Improve RISC-V Perf support using SBI PMU and sscofpmf extension
Next by Date: Re: [v4 00/11] Improve RISC-V Perf support using SBI PMU and sscofpmf extension
Previous by thread: Re: [PATCH] livepatch: Fix leak on klp_init_patch_early failure path
Next by thread: [PATCH v2] Instantiate key with user-provided decrypted data.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]