On 2021/12/13 21:17, Baoquan He wrote: > On 12/10/21 at 02:55pm, Zhen Lei wrote: >> From: Chen Zhou <chenzhou10@xxxxxxxxxx> >> >> Move CRASH_ALIGN to header asm/kexec.h for later use. >> >> Suggested-by: Dave Young <dyoung@xxxxxxxxxx> >> Suggested-by: Baoquan He <bhe@xxxxxxxxxx> > > I remember Dave and I discussed and suggested this when reviewing. > You can remove my Suggested-by. OK, I will do it. > > For this one, I would like to add ack: > > Acked-by: Baoquan He <bhe@xxxxxxxxxx> > >> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx> >> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> >> Tested-by: John Donnelly <John.p.donnelly@xxxxxxxxxx> >> Tested-by: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> >> --- >> arch/x86/include/asm/kexec.h | 3 +++ >> arch/x86/kernel/setup.c | 3 --- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/include/asm/kexec.h b/arch/x86/include/asm/kexec.h >> index 11b7c06e2828c30..3a22e65262aa70b 100644 >> --- a/arch/x86/include/asm/kexec.h >> +++ b/arch/x86/include/asm/kexec.h >> @@ -18,6 +18,9 @@ >> >> # define KEXEC_CONTROL_CODE_MAX_SIZE 2048 >> >> +/* 16M alignment for crash kernel regions */ >> +#define CRASH_ALIGN SZ_16M >> + >> #ifndef __ASSEMBLY__ >> >> #include <linux/string.h> >> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c >> index 6a190c7f4d71b05..5cc60996eac56d6 100644 >> --- a/arch/x86/kernel/setup.c >> +++ b/arch/x86/kernel/setup.c >> @@ -392,9 +392,6 @@ static void __init memblock_x86_reserve_range_setup_data(void) >> >> #ifdef CONFIG_KEXEC_CORE >> >> -/* 16M alignment for crash kernel regions */ >> -#define CRASH_ALIGN SZ_16M >> - >> /* >> * Keep the crash kernel below this limit. >> * >> -- >> 2.25.1 >> > > . >
