On Thu, 09 Dec 2021 09:59:49 -0700
Jonathan Corbet <corbet@xxxxxxx> wrote:
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> writes:
>
> > On Thu, 09 Dec 2021 07:50:07 -0700
> > Jonathan Corbet <corbet@xxxxxxx> wrote:
> >
> >> I don't see that this is going to work either. Is there any reason not
> >> to just make the text read:
> >>
> >> please read the event histogram document Documentation/trace/histogram.rst
> >>
> >> and let automarkup link it in?
> >
> > Hmm, I think we need the following change instead of this.
> > (the label is not in this document, but in the target document.)
> >
> > diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> > index 859fd1b76c63..ea722eae2810 100644
> > --- a/Documentation/trace/histogram.rst
> > +++ b/Documentation/trace/histogram.rst
> > @@ -1,3 +1,5 @@
> > +.. _histogram:
> > +
>
> That would work, but it will have essentially the same effect as what I
> suggested while adding extra markup. I think we can leave the label out
> and keep the plain-text a little cleaner.
Indeed. If automarkup makes a link, we don't need the labels.
BTW, it is nicer to brace it.
please read the event histogram document (Documentation/trace/histogram.rst)
Then, it will be
please read the event histogram document (Event Histograms)
Yanteng, can you update this patch just putting the document file
as above?
Thank you,
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
