Re: [PATCH 04/11] docs/vm: delele three spaces from page_owner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Corbet <corbet@xxxxxxx> 于2021年12月7日周二 01:58写道:
>
> Yanteng Si <siyanteng01@xxxxxxxxx> writes:
>
> > Fix warning as:
> >
> > linux-next/Documentation/vm/page_owner.rst:92: WARNING: Unexpected indentation.
> > linux-next/Documentation/vm/page_owner.rst:96: WARNING: Unexpected indentation.
> > linux-next/Documentation/vm/page_owner.rst:107: WARNING: Unexpected indentation.
>
> A general comment: "fixed a warning" is almost never a useful changelog
> entry.  Instead, talk about what you fixed that was causing the warning;
> that, not the warning itself, is the real problem.
OK! get it.
>
> > Signed-off-by: Yanteng Si <siyanteng@xxxxxxxxxxx>
> > ---
> >  Documentation/vm/page_owner.rst | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> > index 9837fc8147dd..9a3af6aafa09 100644
> > --- a/Documentation/vm/page_owner.rst
> > +++ b/Documentation/vm/page_owner.rst
> > @@ -89,11 +89,11 @@ Usage
> >
> >       Page allocated via order XXX, ...
> >       PFN XXX ...
> > -      // Detailed stack
> > +     // Detailed stack
> >
> >       Page allocated via order XXX, ...
> >       PFN XXX ...
> > -      // Detailed stack
> > +     // Detailed stack
>
> I don't think this is the right fix; instead, this text should be in a
> literal block.
OK, Thanks!

Thanks,
Yanteng




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux