This makes perfect sense, just one minor point: On Fri, Dec 03, 2021 at 08:24:23AM -0800, Dan Schatzberg wrote: > @@ -4390,6 +4390,9 @@ static int mem_cgroup_oom_control_read(struct seq_file *sf, void *v) > seq_printf(sf, "under_oom %d\n", (bool)memcg->under_oom); > seq_printf(sf, "oom_kill %lu\n", > atomic_long_read(&memcg->memory_events[MEMCG_OOM_KILL])); > + seq_printf(sf, "oom_group_kill %lu\n", > + atomic_long_read( > + &memcg->memory_events[MEMCG_OOM_GROUP_KILL])); > return 0; > } oom_control is a cgroup1 file, but group-oom is a cgroup2-only feature. Best to drop this hunk. With that, please add: Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>