From: Vladimir Oltean <vladimir.oltean@xxxxxxx> Date: Tue, 23 Nov 2021 17:09:20 +0000 > On Tue, Nov 23, 2021 at 05:39:34PM +0100, Alexander Lobakin wrote: > > Similarly to dpaa2, enetc stores 5 per-channel counters for XDP. > > Add necessary callbacks to be able to access them using new generic > > XDP stats infra. > > > > Signed-off-by: Alexander Lobakin <alexandr.lobakin@xxxxxxxxx> > > Reviewed-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> > > --- > > Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> Thanks! > These counters can be dropped from ethtool, nobody depends on having > them there. Got it, thanks. I'll remove them in v3 or, in case v2 gets accepted, will send a follow-up patch(es) for removing redundant Ethtool stats. > Side question: what does "nch" stand for? "The number of channels". I was thinking of an intuitial, but short term, as get_xdp_stats_channels is too long and breaks Tab aligment of tons of net_device_ops across the tree. It was "nqs" /number of queues/ previously, but we usually use term "queue" referring to one-direction ring, in case of these stats and XDP in general "queue pair" or simply "channel" is more correct. Thanks, Al