On Tue, Nov 23, 2021 at 08:45:55PM +0200, Andy Shevchenko wrote: > On Tue, Nov 23, 2021 at 05:49:02PM +0100, Wolfram Sang wrote: > > + # Check if we could parse something and the channel number fits > > > + [ "$chan" != "$elem" ] && [ "$chan" -le $max_chans ] || fail "Trigger syntax error: $elem" > > No need to execute `test` twice: > > [ "$chan" != "$elem" -a "$chan" -le $max_chans ] || fail "Trigger syntax error: $elem" On the second thought this might be a different logic... -- With Best Regards, Andy Shevchenko