On Tue, May 07, 2013 at 10:42:53AM +0530, Kishon Vijay Abraham I wrote: > On Monday 06 May 2013 08:10 PM, Mark Brown wrote: > >On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote: > > > >>+ if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) { > >>+ if (palmas_usb->vbus_reg) { > >>+ ret = regulator_enable(palmas_usb->vbus_reg); > >>+ if (ret) { > >>+ dev_dbg(palmas_usb->dev, > >>+ "regulator enable failed\n"); > >>+ goto ret0; > >This is very bad karma, why is the regulator optional? > The platform can provide it's own vbus control in which case this is > not needed. So why is there no interaction with this external VBUS control and how does the driver distinguish between that and an error getting the regulator?
Attachment:
signature.asc
Description: Digital signature