On Fri, May 03, 2013 at 09:50:53PM -0000, Thomas Gleixner wrote: > + /* Init mask cache ? */ > + if (dgc->gc_flags & IRQ_GC_INIT_MASK_CACHE) { > + raw_spin_lock_irqsave(&gc->lock, flags); > + gc->mask_cache = irq_reg_readl(gc->reg_base + ct->regs.mask); > + raw_spin_unlock_irqrestore(&gc->lock, flags); > + } This looks a little weird to me - it seems that it'll re-read this each time any irq is mapped in the domain, which is probably not wanted. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html