On 04/18/2013 03:03 AM, Christian Ruppert wrote: > Dear Stephen and Linus, > > I am responding to this message because it touches the core issue I was > wondering about when integrating pinctrl with GPIO. I think all > unrelated comments in your other messages are valid and will be > addressed in the next iteration of both drivers. > > On Wed, Apr 17, 2013 at 12:32:00PM -0600, Stephen Warren wrote: >> On 04/10/2013 09:45 AM, Christian Ruppert wrote: >>> The pinmux driver of the Abilis Systems TB10x platform based on ARC700 CPUs. >>> Used to control the pinmux and is a prerequisite for the GPIO driver. >> >> Linus already did a review of this, but I have a few extra comments: >> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/abilis,tb10x-iomux.txt b/Documentation/devicetree/bindings/pinctrl/abilis,tb10x-iomux.txt ... >> * A list of pins/groups to apply the settings to. > > This is what the pingrp string refers to. We really don't want to expose > Linux internal pin numbers! I wasn't suggesting a particular naming/numbering scheme for the pins, but simply that the document has to state what that naming/numbering scheme is, so that people know how to fill in the DT. If the naming/numbering scheme exactly matches some HW manual, then it should be enough to say e.g. "see section X in Foo manual", to avoid duplicating the information. If not, then the valid values should be listed in the binding document. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
