On Fri, 2021-10-15 at 15:58 +0800, Cai Huoqing wrote:
> Some patches have been sent, the RFC tag of which is
> outside the subject prefix is incorrect. like this:
> "Subject: [PATCH v2] RFC:"
>
> Perfer "Subject: [RFC PATCH v2]" to "Subject: [PATCH v2] RFC:",
> so add check item for it.
typo of prefer but does this matter enough to make it a test?
Same typo in next patch.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3121,6 +3121,12 @@ sub process {
> "A patch subject line should describe the change not the tool that found it\n" . $herecurr);
> }
>
> +# Check if RFC tags is outside the subject prefix
> + if ($in_header_lines && $line =~ /^Subject:.*patch\s*.*]\s*rfc:/i) {
> + WARN("RFC_TAG_PREFIX",
> + "RFC tag is outside subject prefix, try \"git format-patch --rfc\"\n" . $herecurr);
> + }
> +
> # Check for Gerrit Change-Ids not in any patch context
> if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
> if (ERROR("GERRIT_CHANGE_ID",
