Hi Denis, I love your patch! Yet something to improve: [auto build test ERROR on 39b483aa38995329326988cbc4077422bebc175a] url: https://github.com/0day-ci/linux/commits/Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740 base: 39b483aa38995329326988cbc4077422bebc175a config: x86_64-randconfig-r033-20211011 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 903b30fea21f99d8f48fde4defcc838970e30ee1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4ac420ec20a4c088ebd178ab3d4a345de53b91a2 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740 git checkout 4ac420ec20a4c088ebd178ab3d4a345de53b91a2 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/hwmon/asus_wmi_ec_sensors.c:356:11: error: implicit declaration of function 'wmi_evaluate_method' [-Werror,-Wimplicit-function-declaration] status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input, ^ drivers/hwmon/asus_wmi_ec_sensors.c:356:11: note: did you mean 'wmidev_evaluate_method'? include/linux/wmi.h:24:20: note: 'wmidev_evaluate_method' declared here extern acpi_status wmidev_evaluate_method(struct wmi_device *wdev, ^ 1 error generated. vim +/wmi_evaluate_method +356 drivers/hwmon/asus_wmi_ec_sensors.c 344 345 static int asus_wmi_ec_block_read(u32 method_id, char *query, u8 *out) 346 { 347 struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, 348 NULL }; 349 struct acpi_buffer input; 350 union acpi_object *obj; 351 acpi_status status; 352 353 /* the first byte of the BRxx() argument string has to be the string size */ 354 input.length = (acpi_size)query[0] + 2; 355 input.pointer = query; > 356 status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input, 357 &output); 358 if (ACPI_FAILURE(status)) 359 return -EIO; 360 361 obj = output.pointer; 362 if (!obj || obj->type != ACPI_TYPE_BUFFER) { 363 if (!obj) 364 acpi_os_free(output.pointer); 365 366 return -EIO; 367 } 368 asus_wmi_ec_decode_reply_buffer(obj->buffer.pointer, out); 369 acpi_os_free(output.pointer); 370 return 0; 371 } 372 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip