On Fri, Oct 01, 2021 at 03:47:23AM -0700, David E. Box wrote: > On Fri, 2021-10-01 at 09:16 +0200, Greg KH wrote: > > On Thu, Sep 30, 2021 at 06:28:15PM -0700, David E. Box wrote: > > > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism for > > > activating additional silicon features. Features are enabled through a > > > license activation process. The SDSi driver provides a per socket, ioctl > > > interface for applications to perform 3 main provisioning functions: > > > > > > 1. Provision an Authentication Key Certificate (AKC), a key written to > > > internal NVRAM that is used to authenticate a capability specific > > > activation payload. > > > > > > 2. Provision a Capability Activation Payload (CAP), a token authenticated > > > using the AKC and applied to the CPU configuration to activate a new > > > feature. > > > > > > 3. Read the SDSi State Certificate, containing the CPU configuration > > > state. > > > > > > The ioctl operations perform function specific mailbox commands that > > > forward the requests to SDSi hardware to perform authentication of the > > > payloads and enable the silicon configuration (to be made available after > > > power cycling). > > > > > > The SDSi device itself is enumerated as an auxiliary device from the > > > intel_extended_caps driver and as such has a build dependency on > > > CONFIG_INTEL_EXTENDED_CAPS. > > > > > > Link: https://github.com/intel/intel-sdsi > > > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > > > > I do not see the "required" review that Intel developers need when > > sending stuff to me. What happened here? > > Ah. You were added because of the doc change. Normally, the changes to the driver wouldn't have gone > through you. So it's just a miss on that. But it been through internal review. Then where is the "reviewed-by:" line that shows this happened?