Hi Pierre, Em Thu, 16 Sep 2021 11:36:33 -0500 Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> escreveu: > On 9/16/21 3:59 AM, Mauro Carvalho Chehab wrote: > > An "N" upper letter is not a wildcard, nor can easily be identified > > by script, specially since the USB sysfs define things like. > > bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl > > to convert it into a Regex. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> Thanks! > > I also realized that we have a similar with the 'master' case > > more sysfs-bus-soundwire-master > What: /sys/bus/soundwire/devices/sdw-master-N/revision > /sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes > /sys/bus/soundwire/devices/sdw-master-N/clk_freq > /sys/bus/soundwire/devices/sdw-master-N/clk_gears > /sys/bus/soundwire/devices/sdw-master-N/default_col > /sys/bus/soundwire/devices/sdw-master-N/default_frame_rate > /sys/bus/soundwire/devices/sdw-master-N/default_row > /sys/bus/soundwire/devices/sdw-master-N/dynamic_shape > /sys/bus/soundwire/devices/sdw-master-N/err_threshold > /sys/bus/soundwire/devices/sdw-master-N/max_clk_freq > > If there is an update we should modify this as well for consistency with > sdw-master-<N>? It is on patch 15/30: https://lkml.org/lkml/2021/9/16/198 Regards, Mauro > > > --- > > .../ABI/testing/sysfs-bus-soundwire-slave | 60 +++++++++---------- > > 1 file changed, 30 insertions(+), 30 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-soundwire-slave b/Documentation/ABI/testing/sysfs-bus-soundwire-slave > > index d324aa0b678f..fbf55834dfee 100644 > > --- a/Documentation/ABI/testing/sysfs-bus-soundwire-slave > > +++ b/Documentation/ABI/testing/sysfs-bus-soundwire-slave > > @@ -64,37 +64,37 @@ Description: SoundWire Slave Data Port-0 DisCo properties. > > Data port 0 are used by the bus to configure the Data Port 0. > > > > > > -What: /sys/bus/soundwire/devices/sdw:.../dpN_src/max_word > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/min_word > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/words > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/type > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/max_grouping > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/simple_ch_prep_sm > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/ch_prep_timeout > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/imp_def_interrupts > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/min_ch > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/max_ch > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/channels > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/ch_combinations > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/max_async_buffer > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/block_pack_mode > > - /sys/bus/soundwire/devices/sdw:.../dpN_src/port_encoding > > +What: /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_word > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/min_word > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/words > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/type > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_grouping > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/simple_ch_prep_sm > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/ch_prep_timeout > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/imp_def_interrupts > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/min_ch > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_ch > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/channels > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/ch_combinations > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_async_buffer > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/block_pack_mode > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/port_encoding > > > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_word > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/min_word > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/words > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/type > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_grouping > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/simple_ch_prep_sm > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/ch_prep_timeout > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/imp_def_interrupts > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/min_ch > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_ch > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/channels > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/ch_combinations > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_async_buffer > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/block_pack_mode > > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/port_encoding > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_word > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/min_word > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/words > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/type > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_grouping > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/simple_ch_prep_sm > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/ch_prep_timeout > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/imp_def_interrupts > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/min_ch > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_ch > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/channels > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/ch_combinations > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_async_buffer > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/block_pack_mode > > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/port_encoding > > > > Date: May 2020 > > > > Thanks, Mauro
