On Sun, Sep 12, 2021 at 10:01 PM brookxu <brookxu.cn@xxxxxxxxx> wrote:
>
> From: Chunguang Xu <brookxu@xxxxxxxxxxx>
>
> Introduce misc.events and misc.events.local to make it easier for
I thought Tejun only gave go ahead for misc.events and not for
misc.events.local.
> us to understand the pressure of resources. The main idea comes
> from mem_cgroup. Currently only the 'max' event is implemented,
> which indicates the times the resource exceeds the limit.
>
For future emails, please provide the links to previous discussions
like [1], [2],...
> @@ -36,6 +41,8 @@ enum misc_res_type {
> struct misc_res {
> unsigned long max;
> atomic_long_t usage;
> + atomic_long_t events[MISC_CG_EVENT_TYPES];
Since there is only one event type for now, my recommendation is to
not use the array and just use a single atomic_long_t.
>
> +static const char *const misc_event_name[] = {
> + "max"
> +};
> +
We will not need it if you remove the array in struct misc_res.
Thanks
Vipin
