Hi, Guenter Roeck <linux@xxxxxxxxxxxx> writes: > On Fri, Apr 19, 2013 at 12:28:21AM +0200, Arnaud Ebalard wrote: >> >> Signed-off-by: Arnaud Ebalard <arno@xxxxxxxxxxxx> >> Tested-by: Arnaud Ebalard <arno@xxxxxxxxxxxx> >> --- >> drivers/hwmon/Kconfig | 10 + >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/g762.c | 1159 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 1170 insertions(+) >> create mode 100644 drivers/hwmon/g762.c >> > checkpatch says: > > total: 1 errors, 15 warnings, 0 checks, 1182 lines checked > > Please fix those. Also, please make sure there are spaces around operators. > > Additional comments inline. This is not a complete review; I gave up after > a while. Please fix the problems and resubmit. Thanks for taking the time and sorry for some lame errors (missing spaces around operators, spaces issues, unchecked overflow). Regarding the ssize_t, I will replace it by an int where appropriate; basically all the functions not returning a size value or an error (i.e. those not using sprintf). Will try and resubmit a v1 with all thoses fixed and additional review done after the week end Cheers, a+ -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
