On Wed, Aug 18, 2021 at 07:29:40PM -0700, Kevin Mitchell wrote:
> With the removal of the legacy IDE driver in kb7fb14d3ac63 ("ide: remove
> the legacy ide driver"), this crashpoint no longer points to a valid
> function.
>
> Signed-off-by: Kevin Mitchell <kevmitch@xxxxxxxxxx>
Hah, whoops. Yes. :)
Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
Thanks!
-Kees
> ---
> Documentation/fault-injection/provoke-crashes.rst | 3 +--
> drivers/misc/lkdtm/core.c | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/fault-injection/provoke-crashes.rst b/Documentation/fault-injection/provoke-crashes.rst
> index 18de17354206..3abe84225613 100644
> --- a/Documentation/fault-injection/provoke-crashes.rst
> +++ b/Documentation/fault-injection/provoke-crashes.rst
> @@ -29,8 +29,7 @@ recur_count
> cpoint_name
> Where in the kernel to trigger the action. It can be
> one of INT_HARDWARE_ENTRY, INT_HW_IRQ_EN, INT_TASKLET_ENTRY,
> - FS_DEVRW, MEM_SWAPOUT, TIMERADD, SCSI_QUEUE_RQ,
> - IDE_CORE_CP, or DIRECT
> + FS_DEVRW, MEM_SWAPOUT, TIMERADD, SCSI_QUEUE_RQ, or DIRECT.
>
> cpoint_type
> Indicates the action to be taken on hitting the crash point.
> diff --git a/drivers/misc/lkdtm/core.c b/drivers/misc/lkdtm/core.c
> index 016cb0b150fc..e50e7bfc4674 100644
> --- a/drivers/misc/lkdtm/core.c
> +++ b/drivers/misc/lkdtm/core.c
> @@ -83,7 +83,6 @@ static struct crashpoint crashpoints[] = {
> CRASHPOINT("MEM_SWAPOUT", "shrink_inactive_list"),
> CRASHPOINT("TIMERADD", "hrtimer_start"),
> CRASHPOINT("SCSI_QUEUE_RQ", "scsi_queue_rq"),
> - CRASHPOINT("IDE_CORE_CP", "generic_ide_ioctl"),
> #endif
> };
>
> --
> 2.32.0
>
--
Kees Cook
