On Wed, Jul 21, 2021 at 07:16:09PM +0300, Yishai Hadas wrote: > From: Max Gurtovoy <mgurtovoy@xxxxxxxxxx> > > Now that vfio_pci has been split into two source modules, one focusing > on the "struct pci_driver" (vfio_pci.c) and a toolbox library of code > (vfio_pci_core.c), complete the split and move them into two different > kernel modules. > > As before vfio_pci.ko continues to present the same interface under > sysfs and this change will have no functional impact. > > Splitting into another module and adding exports allows creating new HW > specific VFIO PCI drivers that can implement device specific > functionality, such as VFIO migration interfaces or specialized device > requirements. > > Signed-off-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxx> > --- > drivers/vfio/pci/Kconfig | 30 ++++++++------ > drivers/vfio/pci/Makefile | 8 ++-- > drivers/vfio/pci/vfio_pci.c | 14 ++----- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > drivers/vfio/pci/vfio_pci_core.c | 41 ++++++++++++++++--- > drivers/vfio/pci/vfio_pci_igd.c | 2 +- > drivers/vfio/pci/vfio_pci_intrs.c | 2 +- > drivers/vfio/pci/vfio_pci_rdwr.c | 2 +- > drivers/vfio/pci/vfio_pci_zdev.c | 2 +- > .../pci => include/linux}/vfio_pci_core.h | 2 - > 10 files changed, 66 insertions(+), 39 deletions(-) > rename {drivers/vfio/pci => include/linux}/vfio_pci_core.h (99%) <...> > -#include "vfio_pci_core.h" > +#include <linux/vfio_pci_core.h> > + > +#define DRIVER_VERSION "0.2" <...> > +MODULE_VERSION(DRIVER_VERSION); Please don't add driver versions to the upstream kernel, they useless. Thanks