Hi Samuel, On Wed, Mar 20, 2013 at 1:52 AM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote: > Hi Simon, > > On Wed, Mar 20, 2013 at 09:14:56AM +0100, Samuel Ortiz wrote: >> On Tue, Mar 19, 2013 at 07:01:42PM -0700, Simon Glass wrote: >> > Hi Samuel, >> > >> > On Tue, Mar 19, 2013 at 6:12 PM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote: >> > > On Wed, Mar 20, 2013 at 01:56:52AM +0100, Samuel Ortiz wrote: >> > >> Hi Simon, >> > >> >> > >> On Mon, Feb 25, 2013 at 02:08:35PM -0800, Simon Glass wrote: >> > >> > The ChromeOS Embedded Controller (EC) is an Open Source EC implementation >> > >> > used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3 >> > >> > connected on a bus (such as I2C, SPI, LPC) to the AP. A separate interrupt >> > >> > line is used to indicate when the EC needs service. >> > >> All 6 patches applied to my mfd-next tree, thanks a lot. >> > > Actually, this one fails to build when CONFIG_OF is not set: >> > > >> > > drivers/mfd/cros_ec_i2c.c:130:2: error: implicit declaration of function >> > > ‘of_device_is_available’ [-Werror=implicit-function-declaration] >> > > >> > > If the check in cros_ec_probe_i2c() is really needed then you'll need to inline >> > > of_device_is_available() into a NOP in include/linux/of.h. >> > >> > Actually I suppose that call is not really needed. Would you like to >> > remove it, or shall I send a new patch? >> I will remove it. > This is fixed and pushed. I also fixed some warnings and another build failure > for the case when all of your code is modular. Thank you for that. I don't think I quite understood the different build tests that I needed to do. Regards, Simon > > Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
