Hi Joe, On Tue, Feb 12, 2013 at 7:35 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote: >> This is the base EC implementation, which provides a high level >> interface to the EC for use by the rest of the kernel. The actual >> communcations is dealt with by a separate protocol driver which >> registers itself with this interface. > > trivial logging message comments... Thanks - I will tidy these up in the next spin. > >> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > [] >> +struct cros_ec_device *cros_ec_alloc(const char *name) >> +{ >> + struct cros_ec_device *ec_dev; >> + >> + ec_dev = kzalloc(sizeof(*ec_dev), GFP_KERNEL); >> + if (ec_dev == NULL) { >> + dev_err(ec_dev->dev, "cannot allocate\n"); > > allocation OOM messages aren't useful as there's > a standard one on all allocs without __GFP_WARN > >> +int cros_ec_register(struct cros_ec_device *ec_dev) >> +{ > [] >> + ec_dev->din = kmalloc(ec_dev->din_size, GFP_KERNEL); >> + if (!ec_dev->din) { >> + err = -ENOMEM; >> + dev_err(dev, "cannot allocate din\n"); > > etc... > >> + if (err) { >> + dev_err(dev, "failed to add mfd devices"); > > missing terminating newline > > Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html