Hi Rob,
On 2/1/2013 7:54 AM, Robert Tivy wrote:
> Added a new remoteproc platform device for DA8XX. Contains CMA-based
> reservation of physical memory block. A new kernel command-line
> parameter has been added to allow boot-time specification of the
> physical memory block.
>
> Signed-off-by: Robert Tivy <rtivy@xxxxxx>
This looks good to me. Except one minor nit below:
> +static struct platform_device da8xx_dsp = {
> + .name = "davinci-rproc",
> + .id = 0,
No need to zero initialize here.
> + .dev = {
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> + },
> + .num_resources = ARRAY_SIZE(da8xx_rproc_resources),
> + .resource = da8xx_rproc_resources,
> +};
You can fix that and add my:
Acked-by: Sekhar Nori <nsekhar@xxxxxx>
in case this goes from outside of DaVinci tree.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
