Hi Linus
On Tue, Feb 05, 2013 at 18:30:48, Linus Walleij wrote:
> On Tue, Feb 5, 2013 at 7:36 AM, Vishwanathrao Badarkhe, Manish <manishv.b@xxxxxx> wrote:
>
> > I made following changes, in order to update "dip->p" pointer with
> > correct value:
> >
> > - if (!dpi->p) {
> > + if (IS_ERR_OR_NULL(dpi->p)) {
> > dpi->p = devm_pinctrl_get(dev);
> > - if (IS_ERR_OR_NULL(dpi->p)) {
> > - int ret = PTR_ERR(dpi->p);
> > -
> > - dev_dbg(dev, "no pinctrl handle\n");
> > - /* Only return deferrals */
> > - if (ret == -EPROBE_DEFER)
> > - return ret;
> > - return 0;
> > - }
> > + ret = PTR_ERR(dpi->p);
> > + dev_dbg(dev, "no pinctrl handle\n");
> > + /* Only return deferrals */
> > + if (ret == -EPROBE_DEFER)
> > + return ret;
> > + return 0;
>
> This is based on some old code that I wrote ages ago. Check the pinctrl tree or linux-next for the latest core pin grabbing code.
> Use that instead.
Thanks for your reply.
I have checked with your latest changes regarding pinctrl
in linux-next tree and these changes are working fine for me.
Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
