On Tue, Feb 05, 2013 at 06:36:34AM +0000, Vishwanathrao Badarkhe, Manish wrote:
> I made following changes, in order to update "dip->p" pointer with
> correct value:
>
> - if (!dpi->p) {
> + if (IS_ERR_OR_NULL(dpi->p)) {
> dpi->p = devm_pinctrl_get(dev);
> - if (IS_ERR_OR_NULL(dpi->p)) {
> - int ret = PTR_ERR(dpi->p);
> -
> - dev_dbg(dev, "no pinctrl handle\n");
> - /* Only return deferrals */
> - if (ret == -EPROBE_DEFER)
> - return ret;
> - return 0;
> - }
> + ret = PTR_ERR(dpi->p);
> + dev_dbg(dev, "no pinctrl handle\n");
> + /* Only return deferrals */
> + if (ret == -EPROBE_DEFER)
> + return ret;
> + return 0;
>
> Is this intended change?
The above looks totally broken to me.
Oh, it's using IS_ERR_OR_NULL(), so it's bound to be broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
