Re: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/29/2013 04:32 PM, Thomas Petazzoni wrote:
Dear Florian Fainelli,

On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote:
Fix the driver remove callback to unmap the base register address and
not leak this mapping after the driver has been removed.

Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>
What about using devm_request_and_ioremap() instead, in order to get
automatic unmap on error and in the ->remove() path?

Right now, you are using of_iomap() which eases the task of fetching the resource and getting an ioremap cookie, which I why I kept that.


But maybe it won't work because this memory range is claimed both by
the MDIO driver and the Ethernet driver itself. In that case, you could
use devm_ioremap().
Then we would loose the facility of of_iomap(), but fair enough, it can be inserted as a patch in this serie.

Thanks
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux