On Fri, Jan 4, 2013 at 5:45 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> The IP responsible for the muxing on the Allwinner SoCs are also
> handling the GPIOs on the system. This patch adds the needed driver that
> relies on the pinctrl driver for most of its operations.
>
> The number of pins available for GPIOs operations are already declared
> in the pinctrl driver, we only need to probe a generic driver to handle
> the banks available for each SoC.
>
> This driver has been tested on a A13-Olinuxino.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
Looking mostly good!
> +static int __devinit
> +sunxi_pinctrl_register_gpio_ranges(struct sunxi_pinctrl *pctl)
> +{
> + int id = 0, base = 0, npins = 1, i, prev_pin = -1;
> + struct pinctrl_gpio_range *range;
> +
> + for (i = 0; i < pctl->desc->npins; i++) {
> + const struct sunxi_desc_pin *pin = pctl->desc->pins + i;
> + unsigned pin_num = pin->pin.number;
> +
> + if (prev_pin < 0) {
> + prev_pin = pin_num;
> + base = pin_num;
> + } else if (prev_pin + 1 != pin_num) {
> + range = devm_kzalloc(pctl->dev,
> + sizeof(*range),
> + GFP_KERNEL);
> + if (!range)
> + return -ENOMEM;
> +
> + range->name = "sunxi";
> + range->id = id;
> + range->base = base;
> + range->pin_base = base;
> + range->npins = npins;
> +
> + pinctrl_add_gpio_range(pctl->pctl_dev, range);
> +
> + id++;
> + npins = 1;
> + prev_pin = pin_num;
> + base = prev_pin;
> + } else {
> + prev_pin++;
> + npins++;
> + }
> + }
> +
> + range = devm_kzalloc(pctl->dev, sizeof(*range),
> + GFP_KERNEL);
> + if (!range)
> + return -ENOMEM;
> +
> + range->name = "sunxi";
> + range->id = id;
> + range->base = base;
> + range->pin_base = base;
> + range->npins = npins;
> +
> + pinctrl_add_gpio_range(pctl->pctl_dev, range);
> +
> + return 0;
> +}
Really hairy way to add ranges right?
Registering ranges from the pinctrl side is deprecated and discouraged.
Instead register the ranges from the GPIO driver.
Use gpiochip_add_pin_range() from the GPIO driver.
An example is provided in
drivers/pinctrl/pinctrl-coh901.c
After you have done this, you can probably get rid of this as well:
+static int __init sunxi_gpio_init(void)
+{
+ return platform_driver_register(&sunxi_gpio_driver);
+}
+postcore_initcall(sunxi_gpio_init);
This will become a simple module_init() if you are handling
deferred probe correctly.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
