Hi Steffen, On Mon, Jan 07, 2013 at 14:41:31, Steffen Trumtrar wrote: > On Mon, Jan 07, 2013 at 10:41:30AM +0530, Afzal Mohammed wrote: > > Obtain fb_videomode details for the connected lcd panel using the > > display timing details present in DT. > > +- display-timings: list of different videomodes supported by the lcd > > + panel, represented as childs, can have multiple modes supported, if > > + only one, then it is considered native mode, if multiple modes are > > + provided, native mode can be set explicitly, more details available > > + @Documentation/devicetree/bindings/video/display-timing.txt > Keep in mind that the text combined with... > > + if (of_get_fb_videomode(np, lcdc_info, 0)) { > > + dev_err(&dev->dev, "timings not available in DT\n"); > > + return NULL; > > + } > > + return lcdc_info; > > + } > > ... this is not correct. You are just supporting the first display-timings > subnode (of_get_fb_videomode(..., 0)). Yes right, I will modify the text to reflect what the driver does. Regards Afzal ��.n��������+%������w��{.n�����{����*jg��������ݢj����G�������j:+v���w�m������w�������h�����٥