>>>>> "Mark" == Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> writes: Hi, Mark> On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote: >> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); >> + if (IS_ERR(pinctrl)) >> + dev_warn(&pdev->dev, >> + "pins are not configured from the driver\n"); Mark> Since the driver is happy to continue without the pins why is it Mark> bothering requesting them in the first place? In other words, this Mark> should be a hard error. Sorry, I disagree. As was discussed recently, there's several reasons why the pinctrl call might fail, and not all are fatal (E.G. pinmux already setup by bootloader): http://article.gmane.org/gmane.linux.kernel/1399756 -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
