On Fri, Nov 23, 2012 at 16:21:10, Thierry Reding wrote: > On Fri, Nov 23, 2012 at 10:34:02AM +0000, Philip, Avinash wrote: > > On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote: > > > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote: > > > [...] > > > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > > > + if (IS_ERR(pinctrl)) > > > > + dev_warn(&pdev->dev, "failed to configure pins from driver\n"); > > > > > > I think we already discussed this, but shouldn't this be a fatal error? > > > > I had checked relevant discussion and found this can be warning message. > > This is because most boards don't have pinctrl implemented at this point, > > or may never have. > > > > https://lkml.org/lkml/2012/9/11/369 > > > > Any way I will change to > > dev_warn(&pdev->dev, "unable to select pin group\n"); > > as in other drivers. > > But in case pinctrl isn't implemented, shouldn't the implementation of > devm_pinctrl_get_select_default() just be a no-op? So driver can still exist but pin mux functionality missing. Then warning message will give hints. I am also ok with error message & failure of driver with EPROBE_DEFER, if you want? Thanks Avinash > > Thierry > -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
