On Fri, Nov 09, 2012 at 10:59:30AM +0000, Philip, Avinash wrote: > On Fri, Nov 09, 2012 at 13:22:19, Thierry Reding wrote: > > On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: > > > +#define ECAPCLK_EN BIT(0) > > > +#define ECAPCLK_STOP_REQ BIT(1) > > > > This one doesn't seem to align with the rest. Also, why is bit 0 called > > _EN and bit 1 _STOP_REQ? Couldn't they be made more consistent, i.e. > > _START and _STOP? Or _ENABLE and _DISABLE? > > Ok I will change to PWMSS_ECAPCLK_EN & PWMSS_ECAPCLK_STPO_REQ While at it, maybe move these defines to the pwm-tipwmss.h header file? After all that's the module that accesses the register that contains these bits.
Attachment:
pgpl6fBXrMhMb.pgp
Description: PGP signature
