Re: [PATCH 5/5] hwmon: (coretemp) Add support for Atom CE4110/4150/4170

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 12, 2012 at 11:22:48AM +0200, Jean Delvare wrote:
> On Tue,  9 Oct 2012 14:09:03 -0700, Guenter Roeck wrote:
> > TjMax for the CE4100 series of Atom CPUs was previously reported to be
> > 110 degrees C.
> > 
> > cpuinfo logs on the web show existing CPU types CE4110, CE4150, and CE4170,
> > reported as "model name : Intel(R) Atom(TM) CPU CE41{1|5|7}0 @ 1.{2|6}0GHz"
> > with model 28 (0x1c) and stepping 10 (0x0a). Add the three known variants
> > to the tjmax table.
> > 
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> >  Documentation/hwmon/coretemp |    1 +
> >  drivers/hwmon/coretemp.c     |    7 +++++--
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/coretemp b/Documentation/hwmon/coretemp
> > index 0cc4050..e36960a 100644
> > --- a/Documentation/hwmon/coretemp
> > +++ b/Documentation/hwmon/coretemp
> > @@ -107,6 +107,7 @@ Process		Processor					TjMax(C)
> >  		330/230						125
> >  		E680/660/640/620				90
> >  		E680T/660T/640T/620T				110
> > +		CE4110/4150/4170				110
> 
> Reverse order.
> 
Ah, now I get it ... you mean order within the line, not line-to-line. That
explains the Z670/650 and N570/550 as well. Done (for both).

> >  
> >  45nm		Core2 Processors
> >  		Solo ULV SU3500/3300				100
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index 96ab10c..f6ff76c 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -196,8 +196,11 @@ struct tjmax {
> >  };
> >  
> >  static const struct tjmax __cpuinitconst tjmax_table[] = {
> > -	{ "CPU  230", 100000 },
> > -	{ "CPU  330", 125000 },
> > +	{ "CPU  230", 100000 },		/* Model 0x1c, stepping 2	*/
> > +	{ "CPU  330", 125000 },		/* Model 0x1c, stepping 2	*/
> > +	{ "CPU CE4110", 110000 },	/* Model 0x1c, stepping 10	*/
> > +	{ "CPU CE4150", 110000 },	/* Model 0x1c, stepping 10	*/
> > +	{ "CPU CE4170", 110000 },	/* Model 0x1c, stepping 10	*/
> >  };
> >  
> >  struct tjmax_model {
> 
> I did not check the datasheets but I'll trust you got it right.
> 
I don't have datasheets (the processors don't really exist, after all, if you
try to find them on Intel's web page). The TjMax values are based on
	http://comments.gmane.org/gmane.linux.kernel/1076932

> Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
> 
> Candidate for stable? If so you'll have to change the patch order.
> 
Didn't think about it. Good point. I'll do that.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux