On Wed, Sep 12, 2012 at 12:17 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > the drivers in this patch seem to invert the data-structures a > little - in other words, instead of defining a global list of functions, > they define a list of groups, and for each group, list the functions > that can be selected on to it. > > In turn, that probably requires the core mvebu driver to invert these > data-structures at run-time in order to provide the data the pinctrl > core needs. I think it'd be better to just have each SoC-specific driver > store the data tables in the same format that the pinctrl core needs it, > so that the mvebu pinctrl core won't have to process the data-structures > at all. I sort of agree, not a blocker from my side but it'll surely make the code easier to maintain. Else I think the culprit function needs some commenting to be readable, and writing in plaintext what can be explained by simpler code is not good... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
