Am Freitag, 7. September 2012, 07:38:52 schrieb Kukjin Kim:
> Heiko Stübner wrote:
> > Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs
> > via the device tree. This patch implements dt-support for the
> > s3c24xx arches.
> >
> > The controllers contain only 3 cells, as the underlying gpio controller
> > does not support controlling the drive strength on a gpio level.
> >
> > Tested with the gpio-keys driver on a s3c2416 based machine.
> >
> > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> > Reviewed-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx>
> > ---
>
> [...]
>
> > +#if defined(CONFIG_PLAT_S3C24XX) && defined(CONFIG_OF)
>
> [...]
>
> > +static __init void s3c24xx_gpiolib_attach_ofnode(struct
> > samsung_gpio_chip *chip,
> > + u64 base, u64 offset)
> > +{
>
> [...]
>
> > +}
> > +#elif defined(CONFIG_PLAT_S3C24XX)
>
> Heiko, above line breaks building for other samsung stuff except s3c24xx. I
> fixed with following which has been amended in your patch. If any
> problems, please let me know.
yeah, I see the problem now. Thanks for the fix and sorry to have caused
additional work.
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
