just want to verify that Documentation/firmware_class/README needs fixing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  puttering around, writing a tutorial on how udev and loading
firmware work, and at the very least, it looks like that README file
needs some correcting, not to mention some larger scale rewriting.

  besides at least a couple simple errors:

=====
diff --git a/Documentation/firmware_class/README b/Documentation/firmware_class/README
index 7eceaff..114a806 100644
--- a/Documentation/firmware_class/README
+++ b/Documentation/firmware_class/README
@@ -51,7 +51,7 @@

         if(request_firmware(&fw_entry, $FIRMWARE, device) == 0)
                copy_fw_to_device(fw_entry->data, fw_entry->size);
-        release(fw_entry);
+        release_firmware(fw_entry);

  Sample/simple hotplug script:
  ============================
@@ -61,7 +61,7 @@
        HOTPLUG_FW_DIR=/usr/lib/hotplug/firmware/

        echo 1 > /sys/$DEVPATH/loading
-       cat $HOTPLUG_FW_DIR/$FIRMWARE > /sysfs/$DEVPATH/data
+       cat $HOTPLUG_FW_DIR/$FIRMWARE > /sys/$DEVPATH/data
        echo 0 > /sys/$DEVPATH/loading

  Random notes:
=====

is it fair to say that that whole section on the sample hotplug script
can be tossed?  as i read it, udev is set up to simply call the
/lib/udev/firmware executable with the appropriate command-line args,
so it *seems* that there is no place for a user-supplied hotplug
script anymore.

  is that about correct?  once i get all this worked out, i can submit
one big patch to fix it all at once.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux