Hi Shiraz, On 01/09/12 13:14, shiraz hashim wrote: > On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge <stigge@xxxxxxxxx> wrote: >> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >> pl022->master_info = platform_info; >> pl022->adev = adev; >> pl022->vendor = id->data; >> + /* Point chipselects to allocated memory beyond the main struct */ >> + pl022->chipselects = (int *) pl022 + sizeof(struct pl022); > > This is going beyond memory allocated for chipselects > as it adds 4 * sizeof(struct pl022) bytes to pl022. > > pl022->chipselects = (int *) &pl022[1]; Correct. Thanks for the heads up! Funnily, my previous proposal way actually like you just proposed, but we took the other one since it looked "better". ;-) I'll provide an incremental bugfix patch since Mark already has the commit in his misc.git tree. Thanks again, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
